Re: [NSElib] torsocks5.lua

[Gutek <ange.gutek () gmail com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le 18/07/2011 18:22, David Fifield a écrit :
> This looks nice. The torsocks5 library looks very similar to
> socksHandshake in the proxy.lua library; what are the main differences.

Indeed. As I say in the remarks, I found this proxy-open-socks.nse by
Joao (2009) and proxy.lua is (I guess) the ultimate outcome of his work...
> I would prefer to have a library handling "SOCKS" instead of "Tor
> SOCKS"; Tor-related scripts can do whatever extra they need to deal with
> specifics of Tor.
>
> The status reporting needs to change. Instead of returning a status
> containing an error string, return nil followed by an error string. This
> is the standard used in other libraries and avoids having to do string
> comparison to detect errors.
>
> David Fifield

...and after all, maybe I should work on a patch for proxy.lua instead.
This may be more consistent than a standalone lib.

Thanks for the review anyway,

A.G.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk4kdMoACgkQ3aDTTO0ha7hDMACfdlT0FwF3R4ABJt73GH6kIuno
XTwAn1tvDbw/Pdf/36hoOvf6vjWqeF/t
=HZF0
-----END PGP SIGNATURE-----
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/