Re: Bittorrent and DHT library and scripts

[Patrick Donnelly <batrick () batbytes com>]

Hi Gorjan,

On Tue, Aug 2, 2011 at 1:07 PM, Gorjan Petrovski <mogi57 () gmail com> wrote:
> Hello,
>
> I've written a bittorrent library which allows the user to discover
> peers and nodes using a torrent file or a magnet link as well as
> decode . This is my first library so any comments are welcome.
> You may find it in the nmap-exp/gorjan/ repository under the name
> bittorrent.lua

This is very well done. My only complaint is that some of the "magic"
numbers/strings could use a comment explaining how you came up with
the value. After that's done, please commit it.

Thanks,

-- 
- Patrick Donnelly
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/