Re: [NSE] New script: http-qnap-nas-info.nse

[Duarte Silva <duarte.silva () serializing me>]

On Sunday 29 January 2012 23:53:55 you wrote:
> Hi nmap-dev,
>
> Attached is http-qnap-nas-info.nse which attempts to retrieve the model,
> firware version, and enabled services from a
> QNAP Network Attached Storage (NAS) device.
>
> It has been test on models: TS-859, TS-639, TS-509, TS-459, TS-419, TS-239,
> TS-219, TS-209, TS-101
>
> Example output:
>
> PORT   STATE SERVICE   REASON
> 443/tcp open  https   syn-ack
>
> | http-qnap-nas-info:
> |   Device Model: TS-859
> |   Firmware Version: 3.2.5
> |   Firmware Build: 0410T
> |   Force SSL: 0
> |   SSL Port: 443
> |   WebFS Enabled: 1
> |   Multimedia Station Enabled: 0
> |   Multimedia Station V2 Supported: 1
> |   Multimedia Station V2 Web Enabled: 0
> |   Download Station Enabled: 0
> |   Network Video Recorder Enabled: 0
> |   Web File Manager Enabled: 1
> |   QWeb Server Enabled: 1
> |   QWeb Server Port: 80
> |   Qweb Server SSL Enabled: 0
> |_  Qweb Server SSL Port: 8081
>
> Feedback and suggestions are welcomed.

Hi Brendan,

Nice one! I have some observations:
- the tostring() method is being used with variables that are already known to 
be strings;
- you have a space in the begining of line 54 and 57 (I'm just picky with 
identation :P );
- also in line 57, the http.status is an integer, so you can just use 
"http.status == 200" instead of tostring(data.status):match("200");

Wondering if it would be good to put the "property" strings 
("internalModelName", "version", etc.) to a separate file. It would be easier 
for a user to add new properties in case QNAP adds them (it could also allow 
the user to supply it's own properties). What do you think?

Once again, nice work, regards,
Duarte Silva

Attachment: smime.p7s
Description:

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/