Re: [NSE] ms-sql-info: dependency on ms-sql-discover

[David Fifield <david () bamsoftware com>]

On Tue, Feb 07, 2012 at 09:25:45PM -0600, Tom Sellers wrote:
> All,
>       ms-sql-info has a dependency on ms-sql-discover at line 109.  ms-sql-discover was
> removed from the repo 3/19/2011 (Rev 22680) based on the following discussion:
>
> http://seclists.org/nmap-dev/2011/q1/725
>
> A quick glance at the code and the related discussions gives me the impression that this
> dependency can be removed.
>
> Similarly, the following scripts also show a dependency on ms-sql-discover:
>
> ms-sql-brute.nse
> ms-sql-config.nse
> ms-sql-dump-hashes.nse
> ms-sql-empty-password.nse
> ms-sql-hasdbaccess.nse
> ms-sql-query.nse
> ms-sql-tables.nse
> ms-sql-xp-cmdshell.nse
>
> Unfortunately I can't review the code at this time to suggest a course of action and will
> have to just bring it to the group's attention.

I guess the dependency should be changed to ms-sql-info? I'm assuming
that the other scripts will use the information that ms-sql-info finds
through mssql.Helper.GetDiscoveredInstances.

David Fifield
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/