Re: [patch] Assorted NSE fixes

[Patrick Donnelly <batrick () batbytes com>]

Hi Daniel,

On Tue, May 29, 2012 at 1:42 PM, Daniel Miller <bonsaiviking () gmail com> wrote:
> Also, I noticed an error from http-default-accounts:
> > NSE: http-default-accounts against 192.168.1.253:80 threw an error!
> > ./nselib/data/http-default-accounts-fingerprints.lua:45: variable 'http'
> > is not declared
> > stack traceback:
> >        [C]: in function 'error'
> >        ./nselib/strict.lua:80: in function '__index'
> >        ./nselib/data/http-default-accounts-fingerprints.lua:45: in
> > function <./nselib/data/http-default-accounts-fingerprints.lua:44>
> >        (...tail calls...)
> >        ./scripts/http-default-accounts.nse:275: in function
> > <./scripts/http-default-accounts.nse:222>
> >        (...tail calls...)
>
>
> I think this is related to changes in environment handling in Lua 5.2, but I
> can't dig into it right now. The short fix would be to add 'require "http"'
> to the top of the fingerprints file, but that might be more overhead than is
> necessary. A similar issue cropped up with the packetdecoders.lua file from
> broadcast-listener, so maybe all calls to loadfile should be checked.

Why would there be overhead? I added the missing requires.

-- 
- Patrick Donnelly
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/