Re: [patch] nmap-update/nmap-update.c

[David Fifield <david () bamsoftware com>]

On Wed, Jun 06, 2012 at 09:42:27PM -0600, Littlefield, Tyler wrote:
> I seen the request to fix compiler warnings in the todo. Hopefully
> this is of some use--it's minor and something anyone else could've
> done in a couple of seconds.

> Index: nmap-update.c
> ===================================================================
> --- nmap-update.c     (revision 28862)
> +++ nmap-update.c     (working copy)
> @@ -891,10 +891,11 @@
>               NULL, /* cancel_baton */
>               pool);
>  
> -     err = svn_client_checkout2(&revnum, url, path,
> +     err = svn_client_checkout3(&revnum, url, path,
>               &peg_revision, &revision,
> -             TRUE, /* recurse */
> +                             svn_depth_infinity, /* depth */
>               TRUE, /* ignore_externals */
> +                             FALSE, /* allow_unver_obstructions */
>               ctx, pool);
>       svn_pool_destroy(pool);
>       if (err != NULL)

Thank you for doing this. However there's a reason we use the older
function name here--it's needed in order to compile against the Mac OS X
10.5 SDK, which we use when building the Mac binaries. That SDK doesn't
have the svn_client_checkout3 function.

I'm open to other ways of resolving this warning, that preserve
compatibility.

David Fifield
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/