Re: [NSE] lltd

[Hani Benhabiles <kroosec () gmail com>]

On 07/17/2012 08:49 PM, Henri Doreau wrote:
> Hi Hani,
>
> I can't test the script, but I reviewed the code. Only two minor comments:
>    - please declare get_mac_addr() as local
>    - I wouldn't use the quick_discovery variable in
> QuickDiscoveryPacket() but directly return instead. I think the
> assignment prevents lua from doing a nice proper tail call there (even
> though I doubt it has any impact in this case, I'm nitpicking).
>
> Would be nice if someone else could test the script, but I think it's
> fine if you commit it if you consider that it's ready.
>
> Regards.

Hi Henri,

Thanks for reviewing. I have applied the suggested changes, made further 
tests before committing as r29261.

Cheers,
Hani.

--
Hani Benhabiles

Twitter: https://twitter.com/#!/kroosec
Blog: http://kroosec.blogspot.com

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/