Re: [NSE] SSL support

[Patrick Donnelly <batrick () batbytes com>]

On Sun, Aug 5, 2012 at 8:07 AM, Patrik Karlsson <patrik () cqure net> wrote:
> This is what I ended up committing in r29497.
> A bunch of other problems cropped up when running some of the scripts
> without SSL.
> Specifically those making use of libraries that provide limited
> functionality without SSL.

I looked through your patch. Found a bug:


Index: nselib/mssql.lua
===================================================================
--- nselib/mssql.lua    (revision 29496)
+++ nselib/mssql.lua    (working copy)
@@ -107,7 +107,6 @@
 local math = require "math"
 local match = require "match"
 local nmap = require "nmap"
-local openssl = require "openssl"
 local os = require "os"
 local shortport = require "shortport"
 local smb = require "smb"
@@ -132,7 +131,7 @@
 --
 --                             (Patrik Karlsson, Chris Woodbury)

-HAVE_SSL = (nmap.have_ssl() and pcall(require, "openssl"))
+local openssl, HAVE_SSL = pcall(require, "openssl")

Should be:

+local HAVE_SSL, openssl = pcall(require, "openssl")


Same problem for nselib/smbauth.lua.

-- 
- Patrick Donnelly
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/