Re: [RFC][NSE] Modify shortport.ssl and shortport.http to avoid tcpwrapped services

[David Fifield <david () bamsoftware com>]

On Fri, Sep 14, 2012 at 04:28:55PM -0500, Daniel Miller wrote:
> Checking into the shortport.ssl function, I thought that it could be
> extended to check for tcpwrapped services (while still matching
> ssl-tunnelled services that get detected as tcpwrapped).

It looks fine to me. Here,

> I also added the functionality to shortport.http, and made it match
> if Version detection labels a service http. Here's the patch:

> +http = function (host, port)
> +  return port.version.name == "http" or
> +      ( port.version.name ~= "tcpwrapped" and
> +      port_or_service(LIKELY_HTTP_PORTS, LIKELY_HTTP_SERVICES)(host, port))
> +end

"if Version detection labels a service http": it already does that.
"http" is in LIKELY_HTTP_SERVICES. I think the check
        return port.version.name == "http"
is redundant.

David Fifield
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/