Re: CIDR range capabilities for ipOps (NSE Leftovers - Part 3)

[David Fifield <david () bamsoftware com>]

On Tue, Sep 18, 2012 at 08:05:36AM -0400, Brendan Byrd wrote:
> > I still find it hard to see what is going on here. This is partly
> > because it seems to contain a whole lot of unrealted stylistic changes,
> > for example
> > -  elseif ip:sub(1,3) == '10.' then
> > +  elseif sub(ip,1,3) == '10.' then
> > Maybe you made the patch against an old version of the library or
> > something? At any rate, please remove all those changes if you want the
> > patch to be considered.
>
> I think this was a case of seeing a consistency problem and trying to
> fix it, as I remember seeing it both ways.  Which form is "correct"?

Either way is fine, but it is important not to include these stylistic
changes in patches that change functionality.

David Fifield
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/