Re: [NSE] isakmp aggressive mode and version detection

[Jesper Kückelhahn <dev.kyckel () gmail com>]

Hi David,

Thanks for the commit.

I used hex strings as I thought that it would improve the readability and easy of modification. I'd gladly change it if 
the other method is better suited.


- Jesper

On Jan 28, 2013, at 4:07 AM, David Fifield <david () bamsoftware com> wrote:

> On Sun, Jan 27, 2013 at 10:22:36PM +0100, Jesper Kückelhahn wrote:
> > Thanks for testing, it's nice to see it's working. In order for the
> > version detection to work, the service needs to send at least one
> > known Vendor ID, which it  doesn't in this case. In a successful
> > scenario it will produce the following (debugging) output:
>
> Thanks, I have added your script and library now in r30564.
>
> It seems a bit strange that ike.lua does most of its work using hex
> strings. Is there a reason for that? Mightn't we prefer "\x0a\x00" to
> bin.pack("H", "0a00")?
>
> David FIfield

_______________________________________________
Sent through the dev mailing list
http://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/