Re: [nmap-svn] r32358 - in nmap-exp/d33tah/ncat-colors/ncat: . docs

[Jacek Wielemborek <wielemborekj1 () gmail com>]

2013/9/18  <commit-mailer () nmap org>:
> Author: d33tah
> Date: Wed Sep 18 18:27:51 2013
> New Revision: 32358
>
> Log:
> Rename --color-input to --color.
>
> Modified:
>    nmap-exp/d33tah/ncat-colors/ncat/ChangeLog
>    nmap-exp/d33tah/ncat-colors/ncat/docs/ncat.xml
>    nmap-exp/d33tah/ncat-colors/ncat/ncat_main.c
>
> Modified: nmap-exp/d33tah/ncat-colors/ncat/ChangeLog
> ==============================================================================
> --- nmap-exp/d33tah/ncat-colors/ncat/ChangeLog  (original)
> +++ nmap-exp/d33tah/ncat-colors/ncat/ChangeLog  Wed Sep 18 18:27:51 2013
> @@ -1,6 +1,6 @@
>  # Ncat Changelog ($Id$); -*-text-*-
>
> -o Added --color-input that colors the incoming network input to make it easily
> +o Added --color that colors the incoming network input to make it easily
>    distinguishable from the user wrote to the terminal. [Jacek Wielemborek]
>
>  o Reworked the test program test/test-cmdline-split slightly and added
>
> Modified: nmap-exp/d33tah/ncat-colors/ncat/docs/ncat.xml
> ==============================================================================
> --- nmap-exp/d33tah/ncat-colors/ncat/docs/ncat.xml      (original)
> +++ nmap-exp/d33tah/ncat-colors/ncat/docs/ncat.xml      Wed Sep 18 18:27:51 2013
> @@ -684,11 +684,11 @@
>
>        <varlistentry>
>          <term>
> -          <option>--color-input</option> (Color input)
> -          <indexterm><primary><option>--color-input</option> (Ncat option)</primary></indexterm>
> +          <option>--color</option> (Color input)
> +          <indexterm><primary><option>--color</option> (Ncat option)</primary></indexterm>
>          </term>
>          <listitem>
> -          <para>Issue Ncat with <option>----color-input</option> and it will mark
> +          <para>Issue Ncat with <option>----color</option> and it will mark
>            all the network using red color. Note that this has no effect if Ncat's
>            standard output is redirected to a file.
>            </para>
>
> Modified: nmap-exp/d33tah/ncat-colors/ncat/ncat_main.c
> ==============================================================================
> --- nmap-exp/d33tah/ncat-colors/ncat/ncat_main.c        (original)
> +++ nmap-exp/d33tah/ncat-colors/ncat/ncat_main.c        Wed Sep 18 18:27:51 2013
> @@ -589,7 +589,7 @@
>  "  -v, --verbose              Set verbosity level (can be used several times)\n"
>  "  -w, --wait <time>          Connect timeout\n"
>  "      --append-output        Append rather than clobber specified output files\n"
> -"      --color-input          Mark the incoming data using red color\n"
> +"      --color                Mark the incoming data using red color\n"
>  "      --send-only            Only send data, ignoring received; quit on EOF\n"
>  "      --recv-only            Only receive data, never send anything\n"
>  "      --allow                Allow only given hosts to connect to Ncat\n"
> @@ -637,7 +637,7 @@
>
>      if (o.color && !isatty(STDOUT_FILENO)) {
>          if (o.verbose)
> -            loguser("--color-input was specified, but standard output seems to be redirected, coloring disabled.\n");
> +            loguser("--color was specified, but standard output seems to be redirected, coloring disabled.\n");
>          o.color = 0;
>      }
>
>
> _______________________________________________
> Sent through the svn mailing list
> http://nmap.org/mailman/listinfo/svn

Hi David,

I renamed --color-input to --color. As for grep, looks like they use
nothing fancy apart from isatty and checking if the getenv("TERM")
doesn't contain "dumb":

http://git.savannah.gnu.org/gitweb/?p=grep.git;a=blob;f=src/main.c;h=19750270f25a3f9b021b2abfe5bafc87b7111cdb;hb=HEAD
(2187)
https://lists.gnu.org/archive/html/bug-grep/2012-01/msg00013.html
(should_colorize)

Yours,
Jacek Wielemborek
_______________________________________________
Sent through the dev mailing list
http://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/