Re: [Bulk] Re: [Patch] Upgrade libpcap to 1.5.3

["Gisle Vanem" <gvanem () yahoo no>]

"Jay Bosamiya" <jaybosamiya () gmail com> wrote:

Hi again Jay. We discussed these things privately.

> Since I didn't get any replies at all, I'm going to assume that my patch
> either got lost in the other mails or

We got it the first time. It's here:
 http://seclists.org/nmap-dev/2014/q1/184

> Hence, this mail is both a BUMP as well as a mail with the complete patch
> attached. This time, only the patch need be run and libpcap is directly
> upgraded to 1.5.3.
>
> Attached: libpcap_upgrade_to_1.5.3.patch

In your patch for pcap-int.h:

@@ -239,10 +109,25 @@
typedef int (*setbuff_op_t)(pcap_t *, int);
typedef int (*setmode_op_t)(pcap_t *, int);
typedef int (*setmintocopy_op_t)(pcap_t *, int);
+typedef Adapter *(*getadapter_op_t)(pcap_t *);
...
#ifdef WIN32
 ADAPTER *adapter;
 LPPACKET Packet;

Have you tried to compile this on Win32? I mean, why are there 2 of these?
'Adapter' and  'ADAPTER'; are they the same?

Other than that, I have no objections to your patch. Which brings me back to the 
point (which we discussed in private emails ealier); why does Nmap and chums 
needs it's own "port" of libpcap? Any insiders who can answer that? The offical
libpcap works fine here anyway.

--gv
_______________________________________________
Sent through the dev mailing list
http://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/