Re: [nmap-svn] r33784 - in nmap: . libnetutil nping

[Luis MartinGarcia <luis.mgarc () gmail com>]

:-)

Sometimes one needs to leave written proof of the frustration.

Luis.
On 5 Nov 2014 16:00, <commit-mailer () nmap org> wrote:

> Author: dmiller
> Date: Wed Nov  5 15:02:09 2014
> New Revision: 33784
>
> Log:
> Modify some offensive terminology in comments.
>
> Modified:
>    nmap/libnetutil/ARPHeader.h
>    nmap/nmap_ftp.cc
>    nmap/nping/ProbeMode.cc
>    nmap/osscan2.cc
>    nmap/service_scan.cc
>
> Modified: nmap/libnetutil/ARPHeader.h
>
> ==============================================================================
> --- nmap/libnetutil/ARPHeader.h (original)
> +++ nmap/libnetutil/ARPHeader.h Wed Nov  5 15:02:09 2014
> @@ -217,7 +217,7 @@
>              u8  ar_pln;       /* Protocol Address Length.
>      */
>              u16 ar_op;        /* Operation Code.
>     */
>              u8 data[20];
> -            // Cannot use these because the fucking alignment screws up
> +            // Cannot use these because the four-flushing alignment
> screws up
>              // everything. I miss ANSI C.
>              //u8  ar_sha[6];    /* Sender Hardware Address.
>        */
>              //u32 ar_sip;       /* Sender Protocol Address (IPv4
> address).      */
>
> Modified: nmap/nmap_ftp.cc
>
> ==============================================================================
> --- nmap/nmap_ftp.cc    (original)
> +++ nmap/nmap_ftp.cc    Wed Nov  5 15:02:09 2014
> @@ -341,7 +341,7 @@
>                if (o.debugging)
>                  log_write(LOG_STDOUT, "result of LIST: %s", recvbuf);
>                if (!strncmp(recvbuf, "500", 3)) {
> -                /* fuck, we are not aligned properly */
> +                /* oh dear, we are not aligned properly */
>                  if (o.verbose || o.debugging)
>                    error("FTP command misalignment detected ...
> correcting.");
>                  res = recvtime(sd, recvbuf, 2048, 10, NULL);
>
> Modified: nmap/nping/ProbeMode.cc
>
> ==============================================================================
> --- nmap/nping/ProbeMode.cc     (original)
> +++ nmap/nping/ProbeMode.cc     Wed Nov  5 15:02:09 2014
> @@ -759,7 +759,7 @@
>      /* Transport layer checksum */
>      /* This is totally crazy. We have to tell the kernel EXPLICITLY that
> we
>       * want it to set the TCP/UDP checksum for us. Why the hell is this
> the
> -     * default behavior if it's so fucking difficult to get the IPv6
> source
> +     * default behavior if it's so incredibly difficult to get the IPv6
> source
>       * address?
>       * Additionally, we have to be very careful not to set this option
> when
>       * dealing with ICMPv6 because in that case the kernel computes the
>
> Modified: nmap/osscan2.cc
>
> ==============================================================================
> --- nmap/osscan2.cc     (original)
> +++ nmap/osscan2.cc     Wed Nov  5 15:02:09 2014
> @@ -3169,7 +3169,7 @@
>      if (in_cksum((unsigned short *)ip2, 20) == checksum) {
>        AV.value = "G"; /* The "expected" good value */
>      } else {
> -      AV.value = "I"; /* They fucked it up */
> +      AV.value = "I"; /* They modified it */
>      }
>      *checksumptr = checksum;
>    }
> @@ -3194,7 +3194,7 @@
>    }
>    AV.attribute = "RUD";
>    if (datastart < dataend)
> -    AV.value = "I"; /* They fucked it up */
> +    AV.value = "I"; /* They modified it */
>    else
>      AV.value = "G";
>    AVs.push_back(AV);
>
> Modified: nmap/service_scan.cc
>
> ==============================================================================
> --- nmap/service_scan.cc        (original)
> +++ nmap/service_scan.cc        Wed Nov  5 15:02:09 2014
> @@ -821,6 +821,7 @@
>  // matches in ovector.  The NUL-terminated newly composted string is
>  // placed into 'newstr', as long as it doesn't exceed 'newstrlen'
>  // bytes.  Trailing whitespace and commas are removed.  Returns zero for
> success
> +// FIXME: The newstrlen argument is not actually checked, is it?
>  //
>  // The transform argument is a function pointer. If not NULL, the given
>  // function is applied to all substitutions before they are inserted
> @@ -836,7 +837,7 @@
>    char *subst;
>
>    if (!newstr || !tmpl) return -1;
> -  if (newstrlen < 3) return -1; // fuck this!
> +  if (newstrlen < 3) return -1; // Have a nice day!
>
>    while(*srcstart) {
>      // First do any literal text before '$'
>
> _______________________________________________
> Sent through the svn mailing list
> http://nmap.org/mailman/listinfo/svn
_______________________________________________
Sent through the dev mailing list
http://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/