Request for review: Windows MaxUserPort / WSL2 networking fix (PR #3499)

[山﨑結友 <miagetegorann () gmail com>]

Hi all,

I'd appreciate a review of this PR:
https://github.com/nmap/nmap/pull/3499

Nmap's "Network Performance Improvements" installer option sets
MaxUserPort=65534. On Windows 11, I found that this changes the dynamic
port range from 49152–65535 to 1024–65534. This has been linked to WSL2
mirrored networking failures, with several users tracing the problem
to the Nmap installer:
https://github.com/microsoft/WSL/issues/13454

The PR changes nmap_performance.reg to delete MaxUserPort when the
option is selected, and updates the installation guide. The other
registry settings are unchanged.

The main point I'd like feedback on is whether deleting the existing
value is appropriate. It would undo the setting left by older Nmap
installers, but would also remove values set by an administrator or
another application. An alternative is to stop setting MaxUserPort
and leave any existing value in place.

I tested the registry file against a test key on Windows 11, but
haven't tested the installer end to end or measured the effect on
heavy -sV/NSE workloads. Feedback or testing in those areas would
also be welcome.

Thanks,
yuu61
_______________________________________________
Sent through the dev mailing list
https://nmap.org/mailman/listinfo/dev
Archived at https://seclists.org/nmap-dev/