oss-sec mailing list archives
Re: Retrospective by 'gpg.fail' authors
From: Soatok Dreamseeker <soatok.dhole () gmail com>
Date: Wed, 16 Sep 2026 13:06:33 -0400
Hi Werner, On Wed, Sep 16, 2026 at 11:10 AM Werner Koch <wk () gnupg org> wrote:
On Wed, 16 Sep 2026 02:27, Sam James said:Werner Koch <wk () gnupg org> writes:Hi!Thank you Werner!On Mon, 14 Sep 2026 21:28, Clemens Lang said:(1) A RCE in `gpgsm` 2.4.9 when invoked as `gpgsm --debug all --import bad.cert`, with the bad.cert file at [1]. This is apparently a 0-day,Actually in all versions > 2.2 if you use --debug x509. The result is that you get garbled output on stderr. Using the certificates from their Git repo we have not been able to get more than a segv. That is obvious because the DER is used as printf format string. How it is possible to get a an RCE is not clear to me - at least not with the sample certificate. We need a real reproducers. Maybe the presentation used a custom build. It uses libgcrypt 1.12.4 which is not yet used in any binary we released. This is the fix: if (DBG_X509) - log_debug(skider, skiderlen, "ski is:"); + log_printhex (skider, skiderlen, "ski is:"); We did not used -Wformat-nonliteral which would have caught it due to gcc problems and distros requiring -Werror.You should feel free these days to use whatever -W* you want/need to. No distros should be using -Werror without at least being willing toYes, sure. But 2003 was a different time and that part of the code was simply forgotten:
So... why not delete it? Unmaintained code is a liability (and, categorically, forgotten about code is not being maintained).
Current thread:
- Retrospective by 'gpg.fail' authors Sam James (Sep 12)
- Re: Retrospective by 'gpg.fail' authors Peter Gutmann (Sep 13)
- Re: Retrospective by 'gpg.fail' authors Clemens Lang (Sep 14)
- Re: Retrospective by 'gpg.fail' authors Werner Koch (Sep 15)
- Re: Retrospective by 'gpg.fail' authors Sam James (Sep 15)
- Re: Retrospective by 'gpg.fail' authors Werner Koch (Sep 16)
- Re: Retrospective by 'gpg.fail' authors Soatok Dreamseeker (Sep 16)
- Re: Retrospective by 'gpg.fail' authors Peter Gutmann (Sep 16)
- Re: Removing dead code (was: Retrospective by 'gpg.fail' authors) Jacob Bachmeyer (Sep 17)
- Re: Removing dead code (was: Retrospective by 'gpg.fail' authors) Peter Gutmann (Sep 18)
- Re: Retrospective by 'gpg.fail' authors Werner Koch (Sep 15)
- Re: Retrospective by 'gpg.fail' authors Werner Koch (Sep 17)
