Re: Re: [SECURITY] [DSA-206-1] tcpdump BGP decoding error

[Guy Harris <guy () netapp com>]

On Tue, Dec 10, 2002 at 09:23:28PM -0500, Michael Richardson wrote:
> Is this old news? or new news?

At least some of the changes in their patch are from

        revision 1.25
        date: 2001/10/16 08:00:37;  author: guy;  state: Exp;  lines: +17 -13
        Change suggested by Kaarthik Sivakumar <kaarthik () torrentnet com> -
        various BGP structures have sizes that aren't multiples of the size of
        the most strictly aligned type in the structure, so the compiler will
        pad them out to that size; we should add #defines for the real size, if
        we don't already have them, and use them rather than the result of
        "sizeof".

        Do that even for structures that have sizes that are multiples of the
        size of the most strictly aligned type in the structure, as some
        compilers (e.g., at least some versions of GCC for ARM) apparently pad
        structures to multiples of 4 bytes.

        Add a missing TCHECK2 call.

3.6 was revision 1.21; 3.7 was revision 1.27, so, unless there's a part
of the fix that I missed, 3.7 is OK.
-
This is the TCPDUMP workers list. It is archived at
http://www.tcpdump.org/lists/workers/index.html
To unsubscribe use mailto:tcpdump-workers-request () tcpdump org?body=unsubscribe