Re: CVS is still locked on tcpdump.org

[Michael Richardson <mcr () sandelman ottawa on ca>]

-----BEGIN PGP SIGNED MESSAGE-----


> > > > > "Guy" == Guy Harris <guy () alum mit edu> writes:
    >> From a "cvs commit" here:

    Guy>        cvs server: [22:35:20] waiting for tcpdump's lock in
    Guy>            /tcpdump/master/tcpdump

    Guy> And in "/tcpdump/master/tcpdump" on "cvs.tcpdump.org":

  yeah...

  And:

lox-[/tmp] root 16 #ps aux | grep cvs
tcpdump 25592 33.5  0.5 4896   336 ??  RN   Tue08AM 1555:52.20 cvs --allow-root
tcpdump   690 32.6  0.5 2720   352 ??  RN   Thu02PM  940:52.48 cvs --allow-root
tcpdump   716 31.3  0.5 2924   352 ??  RN   Thu02PM  955:12.77 cvs --allow-root
tcpdump   691  0.0  0.0  792     4 ??  IW         -    0:00.00 cvs --allow-root
tcpdump 25593  0.0  0.0  796     4 ??  IW         -    0:00.00 cvs --allow-root
tcpdump   717  0.0  0.0    0     0 ??  ZW         -    0:00.00 (cvs)


lox-[/tmp] root 18 #netstat -n -f inet | grep 2401
lox-[/tmp] root 19 #

i.e. still no open sockets!

I ktrace them, and they don't seem to be doing anything, i.e. it isn't making
system calls.

I hit them with kill -SEGV, and they stick around!
I hit them with kill -ABRT, ditto.


I copied source code over... to run GDB.

(gdb) bt
#0  0x4815d2b9 in vfprintf ()
#1  0x4815d27b in __divdi3 ()
#2  0x4815d37d in vfprintf ()
#3  0x4815d149 in fprintf ()
#4  0x48123cfa in __assert13 ()
#5  0x804e50e in stdio_buffer_shutdown (buf=0x80cf040) at buffer.c:1384
#6  0x804e2d6 in buf_shutdown (buf=0x80cf040) at buffer.c:1207
#7  0x80870ca in server_cleanup (sig=0) at server.c:4885
#8  0x805e81b in error_exit () at error.c:71
#9  0x805ead7 in error (status=1, errnum=0, 
    message=0x80b6559 "received %s signal") at error.c:212
#10 0x806d4f6 in main_cleanup (sig=6) at main.c:389
#11 0x80a2c34 in SIG_handle (sig=6) at sighandle.c:158
#12 0xbfbfdfdc in ?? ()
#13 0x48123d02 in __assert13 ()
#14 0x804e50e in stdio_buffer_shutdown (buf=0x80cf040) at buffer.c:1384
#15 0x804e2d6 in buf_shutdown (buf=0x80cf040) at buffer.c:1207
#16 0x80870ca in server_cleanup (sig=0) at server.c:4885
#17 0x805e81b in error_exit () at error.c:71
#18 0x805ead7 in error (status=1, errnum=0, 
    message=0x80b6559 "received %s signal") at error.c:212
#19 0x806d4f6 in main_cleanup (sig=6) at main.c:389
#20 0x80a2c34 in SIG_handle (sig=6) at sighandle.c:158
- ---Type <return> to continue, or q <return> to quit--- 
#21 0xbfbfdfdc in ?? ()
#22 0x48123d02 in __assert13 ()
#23 0x804e50e in stdio_buffer_shutdown (buf=0x80cf040) at buffer.c:1384
#24 0x804e2d6 in buf_shutdown (buf=0x80cf040) at buffer.c:1207
#25 0x80870ca in server_cleanup (sig=0) at server.c:4885
#26 0x805e81b in error_exit () at error.c:71
#27 0x805ead7 in error (status=1, errnum=0, 
    message=0x80b6559 "received %s signal") at error.c:212
#28 0x806d4f6 in main_cleanup (sig=6) at main.c:389
#29 0x80a2c34 in SIG_handle (sig=6) at sighandle.c:158
#30 0xbfbfdfdc in ?? ()
#31 0x48123d02 in __assert13 ()
#32 0x804e50e in stdio_buffer_shutdown (buf=0x80cf040) at buffer.c:1384
... on and on and on...

Let's see how to file a bug report....
I went to www.cvshome.org and tried to file an 'issue'. I failed to find a way.
The search was really a loss. 


I applied the following patch:


istari-[/j/src/cvs-1.11.5/src] mcr 1031 %diff -u error.c.orig error.c
- --- error.c.orig        Mon Feb  3 15:20:22 2003
+++ error.c     Mon Feb  3 15:14:29 2003
@@ -64,6 +64,15 @@
 void
 error_exit PROTO ((void))
 {
+       static int exiting=0;
+
+    if(exiting) {
+       exit(EXIT_FAILURE); 
+    }
+    exiting++;
+
+    /* we could SEGV below and re-enter here */
+
     rcs_cleanup ();
     Lock_Cleanup ();
 #ifdef SERVER_SUPPORT

I am on:
lox-[~mcr/src/cvs-1.11.5/src] root 54 #uname -a
NetBSD lox.sandelman.ottawa.on.ca 1.6_STABLE NetBSD 1.6_STABLE (NETSERV) #4: Mon Dec 30 00:39:13 EST 2002     mcr () 
istari sandelman ottawa on ca:/j/netbsd/obj/NETSERV i386

]       ON HUMILITY: to err is human. To moo, bovine.           |  firewalls  [
]   Michael Richardson, Sandelman Software Works, Ottawa, ON    |net architect[
] mcr () sandelman ottawa on ca http://www.sandelman.ottawa.on.ca/ |device driver[
] panic("Just another Debian GNU/Linux using, kernel hacking, security guy"); [
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)
Comment: Finger me for keys

iQCVAwUBPj7PgYqHRg3pndX9AQG3iAQA6dCfhtMS5Ol33xvJ3rloyjTBOk5xPLm4
MOFR0/Pf70nyE1ZHza9AkD8+vKSb2+GrPUVp0Vh8phPo+0gxKE+8j9TWInpaLjTq
5Tm+/sucyjTT8fPmwQYUfLA1Gx/n221cquR8im1vOqj+Mbg86PQg/bhUX43Vsfrp
hI/YCyxU2Qo=
=wKav
-----END PGP SIGNATURE-----
-
This is the TCPDUMP workers list. It is archived at
http://www.tcpdump.org/lists/workers/index.html
To unsubscribe use mailto:tcpdump-workers-request () tcpdump org?body=unsubscribe