Re: beta1

[Neil Spring <nspring () cs washington edu>]

On Nov 16, 2003, at 2:34 AM, Guy Harris wrote:
> On Sat, Nov 15, 2003 at 03:38:53PM -0800, Guy Harris wrote:
> > I've checked in a different variant - the configure script figures out
> > how _U_ should be defined, and sets up the Makefile to define it (and
> > the MSVC++ project file is set up to define it as an empty string), 
> > and
> > I just added _U_'s to the rcsid definitions without moving them.
>
> I've done the same for tcpdump, removed the definition of "_U_" from
> "interface.h", and undid the moving of "rcsid[]" arrays and addition of
> includes of "interface.h", as they're no longer necessary.

Yes, that seems cleaner.

I've attached a patch against current cvs that adds _U_ to unused 
function parameters.  The only warnings that remain on my system are of 
signed / unsigned comparisons and no-op statements on a big-endian 
machine.  I don't know if it's better to apply this patch or to remove 
the unused parameters of functions that are not called indirectly via 
function pointers.   (I'm happy to submit the latter if desired).

thanks,
-neil

Attachment: tcpdump.unusedvars.patch
Description:

Attachment: PGP.sig
Description: This is a digitally signed message part