Re: pcap.c patch

["Mark Pizzolato" <List-tcpdump-workers () subscriptions pizzolato net>]

On Thursday, March 25, 2004 2:36 PM, Guy Harris said:

> On Mar 24, 2004, at 10:58 AM, Gisle Vanem wrote:
>
> > A small patch for DLT_SYMANTEC:
> > And other Win compilers besides MSVC have <unistd.h>.
> >
> > --- libpcap-2004.03.24/pcap.c   Tue Mar 23 20:18:07 2004
> > +++ pcap.c      Wed Mar 24 18:12:06 2004
> > @@ -49,7 +49,7 @@
> >  #include <stdio.h>
> >  #include <stdlib.h>
> >  #include <string.h>
> > -#ifndef WIN32
> > +#ifndef _MSC_VER
>
> Do *all* Windows compilers other than MSVC++ have <unistd.h>?  Cygwin
> GCC presumably does, but what about MinGW, for example?

MinGW (2.0) has a unistd.h
Microsoft Visual Studio 6 DOES NOT
Microsoft Visual Studio .NET DOES NOT
Microsoft Visual Studio .NET 2003 DOES NOT

Since we're talking about compilers in the WIN32 space....

MinGW and all the Microsoft Compilers have a built-in #define for _WIN32
MinGW has a built-in #define for WIN32
None of the Microsoft compilers have a build-in for WIN32, however, projects
created by the wizard in Microsoft Visual Studio 6, by default add the
equivalent of a -DWIN32 to the compile lines.  The Project wizards in both
of the Visual Studio .NET compilers DO NOT add the equivalent of a -DWIN32
to created projects.

It would seem easer for the WIN32 world if pcap, etc used _WIN32 instead of
WIN32, which has to be added to user compiler arguments for those using
later Microsoft Compilers.


-
This is the TCPDUMP workers list. It is archived at
http://www.tcpdump.org/lists/workers/index.html
To unsubscribe use mailto:tcpdump-workers-request () tcpdump org?body=unsubscribe