Re: USB support in libpcap

["Abeni Paolo" <paolo.abeni () telecomitalia it>]

on Sun 4/1/2007 11:46 PM Guy Harris wrote:
> Paolo, do you have any comments on the changes?

The only issue I see is the following:

I think that the following line is not good:
622c693
<       pkth.len = info.hdr->urb_len + sizeof(pcap_usb_header);
---
>       pkth.len = info.hdr->data_len + sizeof(pcap_usb_header);

The 'packet length' (that is: the length of the URB associated to the current usbmon event) is definitive
info.hdr->urb_len + sizeof(pcap_usb_header), while the latter is the number of bytes effectively available.

ciao,

Paolo
--------------------------------------------------------------------

CONFIDENTIALITY NOTICE

This message and its attachments are addressed solely to the persons above and may contain confidential information. If 
you have received the message in error, be informed that any use of the content hereof is prohibited. Please return it 
immediately to the sender and delete the message. Should you have any questions, please contact us by replying to 
webmaster () telecomitalia it.

        Thank you

                                        www.telecomitalia.it

--------------------------------------------------------------------

<<winmail.dat>>

-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.