Re: [libpcap] libpcap 'inbound'/'outbound' filter fixes for Linux (#3)

[Michael Richardson <mcr () sandelman ca>]

> > > > > "David" == David Ward <reply+i-2621989-4d73cbe91d92dde3eff5e1859db3c6b41d58755f-25774 () reply github com> writes:
    David> I'm sending a couple of fixes to the 'inbound' and 'outbound'
    David> filters in libpcap affecting Linux. I have compiled and
    David> tested under Linux as well as FreeBSD (to make sure it
    David> doesn't affect non-Linux builds).

    David> Note that the behavior of the 'inbound' filter for Linux
    David> cooked captures is slightly modified, with the intent of
    David> making the meaning of 'inbound' consistent across all link
    David> types and with pcap_setdirection(). Since installing an
    David> 'inbound' filter for Linux cooked captures into the kernel
    David> was broken anyway, it doesn't seem that there would be any
    David> impact.

    David> I'm not sure if there is a more preferred way to handle the
    David> LSF- or PF_PACKET-specific includes/defines in gencode.h.

    David> Please let me know if there are any questions or
    David> comments. Thank you.

    David> You can merge this Pull Request by running:

    David>   git pull https://github.com/dpward/libpcap master

    David> Or you can view, comment on it, or merge it online at:

    David>   https://github.com/mcr/libpcap/pull/3

I merged it, it looked good to me.

-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.