Re: [RFC] Addition of link-layer header types for PCI, PCI-X, and PCI-Express

[Aki Van Ness via tcpdump-workers <tcpdump-workers () lists tcpdump org>]

> --- Begin Message ---
>
>
> From: Aki Van Ness <aki.vanness () gmail com>
>
> Date: Sat, 24 Oct 2020 23:43:17 -0400
>
> On Sat, Oct 24, 2020 at 5:32 PM Michael Richardson <mcr () sandelman ca> wrote:
> > Aki Van Ness <aki.vanness () gmail com> wrote:
> >     > Yeah it might be possible to use something like a single DLT. The issue
> >     > I can possibly forsee with that is PCI, PCI-X, and PCI-Express are all
> >     > slightly different enough to be a pain to group together into a single
> >     > structure.
> >
> >     > It might be better to have either each type be its own DLT or if it
> >     > must be one DLT a layered approach with a meta-header of sorts that
> >     > just describes some of the generic information about the link, like
> >     > it's type, etc. then have a sub-section whose interpretation is
> >     > dependent on the link type.
> >
> >     > I'm more partial towards the former than the latter personally, but I
> >     > understand not wanting to add a bunch of DLTs at once.
> >
> > If you prefer to use three/four DLTs, that's probably not a problem.
> > If you wind up needing 20, then a distinguished union is probably a better
> > solution.  (uhm. "distinguished union" seems not the be term I want....)
> > A layered solution.
> >
> > https://github.com/the-tcpdump-group/libpcap/blob/master/doc/DLT_ALLOCATE_HOWTO.md
>
> Okay, that sounds fair.
>
> Would the best thing for me to do is to just spin up a PR for libpcap
> to add the DLTs / Link types as PoC and get feedback there?
>
> --- End Message ---
_______________________________________________
tcpdump-workers mailing list
tcpdump-workers () lists tcpdump org
https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers