Re: [Wireshark-commits] rev 30586: /trunk/ /trunk/: configure.in

[Guy Harris <guy () alum mit edu>]

On Oct 16, 2009, at 3:52 PM, Jeff Morriss wrote:

> guy () wireshark org wrote:
> > http://anonsvn.wireshark.org/viewvc/viewvc.cgi? 
> > view=rev&revision=30586
> >
> > User: guy
> > Date: 2009/10/16 03:28 PM
> >
> > Log:
> > Putting the AC_CANONICAL_xxx macro(s) *after* AC_INIT seems to  
> > work, and
> > could fix cross-compilation problems, according to Jeff Morriss, and
>
> I should also mention that I only think it should work because of this
> commit which is what added the AC_CANONICAL macro there (together with
> CC_FOR_BUILD) in the first place:
>
> http://anonsvn.wireshark.org/viewvc?view=rev&revision=19753

Which was a fix for bug 1185:

        https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1185

The patch for that bug added an AC_CANONICAL_BUILD call between an  
AC_CANONICAL_HOST call and an AC_CANONICAL_TARGET call; the change in  
question, however, added a commented-out AC_CANONICAL_BUILD and also  
commented out the existing AC_CANONICAL_HOST, and added the comment  
from the autoconf documentation:

dnl The user is encouraged to use either `AC_CANONICAL_BUILD', or
dnl `AC_CANONICAL_HOST', or `AC_CANONICAL_TARGET', depending on the
dnl needs.  Using `AC_CANONICAL_TARGET' is enough to run the two other
dnl macros.

In revision 19752, the AC_CANONICAL_ calls were after the AC_INIT  
call.  The "Have autoconf generate "ustar" tar files by default. This  
should let us have paths longer than 99 characters." change was the  
one that moved them before the AC_INIT call.  Gerald?  Why was that  
move done?
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe