Re: Linked bug reports

[Francesco Fondelli <francesco.fondelli () gmail com>]

Hi Krishnamurthy, Guy, all,

please take into consideration the possibility to add 6610 on top of 6521.

In 6521 GAL is introduced in packet-mpls.h

Index: epan/dissectors/packet-mpls.h
===================================================================
--- epan/dissectors/packet-mpls.h       (revision 39670)
+++ epan/dissectors/packet-mpls.h       (working copy)
@@ -30,12 +30,16 @@
 #ifndef PACKET_MPLS_H
 #define PACKET_MPLS_H

-/* Special labels in MPLS */
+/*
+ * Special labels in MPLS
+ * (FF: www.iana.org/assignments/mpls-label-values/mpls-label-values.txt)
+ */
 enum {
     LABEL_IP4_EXPLICIT_NULL = 0,
     LABEL_ROUTER_ALERT,
     LABEL_IP6_EXPLICIT_NULL,
     LABEL_IMPLICIT_NULL,
+    LABEL_GAL = 13,
     LABEL_OAM_ALERT = 14,
     LABEL_MAX_RESERVED = 15,
     LABEL_INVALID = 0xffffffff


Krishnamurthy... you should made few changes like:

if (label == 0x0D) {
}

if (label == LABEL_GAL) {
}

I believe it will be cleaner.

hope this helps
thanks
ciao
FF

On Tue, Nov 22, 2011 at 7:45 PM, Guy Harris <guy () alum mit edu> wrote:
> On Nov 22, 2011, at 10:44 AM, Krishnamurthy Mayya wrote:
>
> > Thanks a lot Harris.Now i have submitted a single bug ( Bug 6610 in bugzilla) with all the required attachments and 
> > marked the previous bugs as duplicate which are no longer need to be referred. This would be fine right??
>
> Yes.
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe