Re: [Wireshark-commits] rev 39350: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bittorrent.c packet-manolito.c

[Guy Harris <guy () alum mit edu>]

On Oct 10, 2011, at 4:34 PM, wmeier () wireshark org wrote:

> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=39350
>
> User: wmeier
> Date: 2011/10/10 04:34 PM
>
> Log:
> Fix bugs which caused certain fields to display with the wrong endianness;
> Specifically: some proto_tree_add_item() 'encoding' args were incorrect.

A lot of these bugs appear to be the result of developers typing "item" when they mean "uint" - i.e., they extracted a 
field from the packet in order to use its value later in the dissection, and then, in order to put it into the protocol 
tree without re-fetching it, they intended to do

        proto_tree_add_uint(..., value);

but instead typed

        proto_tree_add_item(..., value);

(Another reason why I'm more and more inclined to believe that the current way dissectors are written is much too 
low-level.)
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe