Re: [Wireshark-commits] rev 50896: / /trunk/doc/: README.qt /trunk/epan/: prefs-int.h prefs.c prefs.h uat-int.h uat.h /trunk/ui/qt/: CMakeLists.txt Makefile.common QtShark.pro elided_label.cpp elided_label.h /trunk/: ...

[Gerald Combs <gerald () wireshark org>]

On 7/25/13 5:24 PM, Evan Huus wrote:
> Nevermind, found the missing location and added it in r50898.
>
> The Qt port has way too many build steps you have to update right now...

We currently support qmake (and Qt Creator), Autotools, and CMake in
ui/qt. We might be able to get qmake to use Makefile.common (e.g. by
adding "!include( Makefile.common ) to QtShark.pro" but this would start
unraveling the next time anyone added a new class or form inside Qt
Creator. We could also go the other direction and have qmake generate
our file lists from QtShark.pro:

unix {
    COMMON_INC = "$$PWD/Makefile.common.qt"
    system(echo "$$LITERAL_HASH Automatically generated by \
        qmake + QtShark.pro. Do not edit" > $$COMMON_INC)
    system(echo "WIRESHARK_QT_SRC = " $$SOURCES >> $$COMMON_INC)
    system(echo "MOC_HDRS = " $$HEADERS >> $$COMMON_INC)
    system(echo "UI_FILES = " $$FORMS >> $$COMMON_INC)
}

I'd be OK with either solution.

BTW, it looks like you can pull Makefile-style definitions into CMake.
This would make maintenance easier everywhere, not just in ui/qt:

https://github.com/berenm/xoreos/blob/a187e94eca041c7c53c76e943483fcaa612cbf4a/cmake/CMakeAM.cmake


___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe