Re: Segmentation fault on tshark

[Pascal Quantin <pascal.quantin () gmail com>]

2015-01-08 20:54 GMT+01:00 Alexis La Goutte <alexis.lagoutte () gmail com>:

> Hi,
>
>
> There is a problem with commit
> a323f0ce3ed46bba7f593790da2256180ac479f2
> Author: Robert Grange <robionekenobi () bluewin ch>
> Date:   Sat Dec 27 17:46:33 2014 +0100
>
>     packet-mq: Add New Def, Reformat Lines, re-order val_str def
>
>     Add missing definition, add new definition, Reformat some lines
>     Re-order the value_string used with ext_value_string definition
>     so they are in asc ASCII order as the ext_value_string is now
>     sorted before first use
>
>     renamed own tvb_get... funct to new tvb_get_guintxx funct
>     and deleted own tvb_get... funct
>     use ptvcursor_ funct instead of own macro to increment offset
>     removed <epan/tvbuff.h> in *.c files
>     correct [-Wunused-const-variable]
>
> tshark don't launch after : Segmentation fault (see also buildbot)
>
> it is coming from _try_mq_vals_sort(GET_VALS_EXTP(StructID));
>
> Somebody, have a idea to fix ? or revert the change ?
>
> (Also, i don't like the idea of "sort" value_string for all start of
> tshark/wireshark...)
>
> Regards,
Hi Alexis,

I uploaded a fix here: https://code.wireshark.org/review/#/c/6420/
But I also dislike the systematic quicksort at each start...

Pascal.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe