Re: Main branch is not compilable if HAVE_KERBEROS

[Guy Harris <guy () alum mit edu>]

On Apr 24, 2016, at 8:55 AM, Jakub Mazur <kubsztal1978 () gmail com> wrote:

> there is a compilation error when mentioned switch is not defined:
>
>   CC       packet-dcerpc-netlogon.lo
> packet-dcerpc-netlogon.c: In function 'get_keytab_as_list':
> packet-dcerpc-netlogon.c:6561:46: error: unused parameter 'p_pass_list' [-Werror=unused-parameter]
>  static guint32 get_keytab_as_list(md4_pass **p_pass_list, const char* ntlm_pass)
>                                               ^
> packet-dcerpc-netlogon.c:6561:71: error: unused parameter 'ntlm_pass' [-Werror=unused-parameter]
>  static guint32 get_keytab_as_list(md4_pass **p_pass_list, const char* ntlm_pass)

You don't have an up-to-date version of the main branch; in the current version, get_keytab_as_list() isn't even 
*compiled* if HAVE_KERBEROS isn't defined.  If you don't have

commit da63bcdc76a842d95fa68fb7b32d8d761f2cd491
Author: Alexis La Goutte <alexis.lagoutte () gmail com>
Date:   Thu Apr 21 13:48:35 2016 +0200

    netlogon (DCERPC): fix build error unused parameter when don't have KERBEROS lib
    
    Reported by Uli https://www.wireshark.org/lists/wireshark-dev/201604/msg00172.html and Benjamin 
https://code.wireshark.org/review/#/c/14971/
    
    Use fix proposed by Guy https://www.wireshark.org/lists/wireshark-dev/201604/msg00176.html

in your checked-out version, do a pull to get it.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe