Re: make-version.pl "problems"

[Anders Broman <anders.broman () ericsson com>]

Hi,
Thanks for looking in to it but
Still not completely ok :-(

Line 551, 578
$line = sprintf("$1%d$2\n"
I removed \n

But there is still problems with
Debaian/changelog
/CMakeLists.txt
./configure.ac

Regards
Anders
-----Original Message-----
From: wireshark-dev-bounces () wireshark org [mailto:wireshark-dev-bounces () wireshark org] On Behalf Of Gerald Combs
Sent: den 2 januari 2017 18:32
To: Developer support list for Wireshark <wireshark-dev () wireshark org>
Subject: Re: [Wireshark-dev] make-version.pl "problems"

Change 19508 should fix both of these issues.

On 1/2/17 6:20 AM, Anders Broman wrote:
> Hi,
>
> I recently ported the updated make-version.pl to my local SVN based 
> Wireshark clone and have some problems on Windows:
>
> With these settings
>
>  
>
> my $set_version = 1;
>
> my $set_release = 1;
>
>  
>
> Cmake failed complaining on path
>
> I changed line 546 from:
>
> for $filedir ("epan", "wiretap") { # "wsutil"
>
> to:
>
> for $filedir ("$srcdir/epan", "$srcdir/wiretap") {  # "wsutil"
>
>  
>
> and 574
>
> from
>
> for $filedir ("epan", "wiretap") { # "wsutil"
>
> to
>
> for $filedir ("$srcdir/epan", "$srcdir/wiretap") {  # "wsutil"
>
>  
>
> Is this something that can go into the released version?
>
>  
>
> Additionally the changed files get "wrong line endings" as the script 
> seems to add UNIX style line endings and I have them as eol-style native.
>
>  
>
> Regards
>
> Anders
>
>  
>
>  
>
>
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>              
> mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe