packet-rpc.c does not call an rpc sub-dissector when there are no parameters or there is no response

[Richard Sharpe <realrichardsharpe () gmail com>]

Hi folks,

In packet-rpc.c we see this:

        /*
         * Don't call any subdissector if we have no more date to dissect.
         */
        if (tvb_reported_length_remaining(tvb, offset) == 0) {
                return TRUE;
        }

However, this is wrong, IMO.

One of the things that our dissector functions does is insert items
like "PROCNAME Reply" etc against the procedure etc, but I would also
like to add text like "void" for void parameters etc.

Indeed, dissection of the NULL procedure doesn't show much useful ...

Does anyone see a problem with changing it to call the sub-dissector
even when there is no more data to dissect?

I guess one possibility is that existing dissectors might fail :-)

-- 
Regards,
Richard Sharpe
(何以解憂？唯有杜康。--曹操)
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe