Re: Annoying deviances from the 802.11-2016 spec in the names of cipher suites

[Alexis La Goutte <alexis.lagoutte () gmail com>]

Hi Richard,

See inline,

On Thu, Nov 29, 2018 at 4:49 PM Richard Sharpe <realrichardsharpe () gmail com>
wrote:

> Hi folks,
>
> I notice that the names used in the code for the 802.11 dissector
> deviate in annoying ways from IEEE 802.11-2016.
>
> For example:
>
> static const value_string ieee80211_rsn_cipher_vals[] = {
>   {0, "NONE"},     // Spec says: Use group cipher suite
>   {1, "WEP (40-bit)"},  // Spec says: WEP-40
>   {2, "TKIP"},
>   {3, "AES (OCB)"},  // Spec says: Reserved
Reserved (ex-AES(OCB))

>   {4, "AES (CCM)"},  // Spec says: GCMP-128
>   {5, "WEP (104-bit)"}, // Spec says: WEP-104
>   {6, "BIP (128)"},   // Spec says: BIP-CMAC-128
>   {7, "Group addressed traffic not allowed"},
>   {8, "GCMP (128)" }, // Spec says: GCMP-128
>   {9, "GCMP (256)" }, // Spec says: GCMP-256
>   {10, "CCMP (256)" }, // Spec says: CCMP-256
>   {11, "BIP (GMAC-128)" }, // Spec says: BIP-GMAC-128
>   {12, "BIP (GMAC-256)" }, // Spec says: BIP-GMAC-256
>   {13, "BIP (CMAC-256)" }, // Spec says: BIP-CMAC-256
>   {0, NULL}
> };
>
> I think we should conform to the spec as far as possible.
>
> Does anyone have any objections to me fixing these?
>
> No problem... there is a lot of other change needed...

> --
> Regards,
> Richard Sharpe
> (何以解憂？唯有杜康。--曹操)(传说杜康是酒的发明者)
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request () wireshark org
> ?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe