Wireshark mailing list archives
Re: Regenerating packet-parlay.c
From: Luke Mewburn <luke () mewburn net>
Date: Thu, 30 Apr 2020 10:41:25 +1000
On 20-04-30 10:35, Luke Mewburn wrote:
| As to the problem; looking at the use of .keys() in wireshark_gen.py,
| there's a couple of places where the code is either:
| - get_intlist(), sorted:
| ret = list(ex_hash.keys())
| ret.sort()
| return ret
| - get_exceptionList(), unsorted:
| ret = list(ex_hash.keys())
| return ret
|
| Both could be simplified to an ordered result using sorted():
| ret = sorted(ex_hash.keys())
| return ret
I actually meant:
ret = sorted(ex_hash)
return ret
Because sorted() takes an iterable.
That seems to work in both python2 and python3.
Luke.
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives: https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Regenerating packet-parlay.c Jaap Keuter (Apr 29)
- Re: Regenerating packet-parlay.c Gerald Combs (Apr 29)
- Re: Regenerating packet-parlay.c Luke Mewburn (Apr 29)
- Re: Regenerating packet-parlay.c Luke Mewburn (Apr 29)
- Re: Regenerating packet-parlay.c Jaap Keuter (Apr 30)
- Re: Regenerating packet-parlay.c Luke Mewburn (Apr 30)
- Re: Regenerating packet-parlay.c Jaap Keuter (Apr 30)
- Re: Regenerating packet-parlay.c Luke Mewburn (Apr 29)
- Re: Regenerating packet-parlay.c Gerald Combs (Apr 29)
