Re: Why tvb_get_bits() assumes Big Endian?

[Tomasz Moń <desowin () gmail com>]

On Thu, Jul 30, 2020 at 9:18 AM Roland Knall <rknall () gmail com> wrote:
> Putting the complexity in the common code will increase the complexity for a lot of other stuff which relies on this 
> functionality. Also you run the risk of increasing dissection time for more protocols, then if you handle it 
> specifically.
>
> That would be my reasoning against it

Having the function take quite important parameter (encoding) and not
using it at all is pretty bad. When someone tries to use
tvb_get_bits() with ENC_LITTLE_ENDIAN the issue becomes apparent.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe