Re: Compile error on netbsd

[David Fifield <david () bamsoftware com>]

On Mon, Aug 31, 2009 at 09:13:15AM -0400, Jay Fink wrote:
> I tried a few different approaches this morning and of course - the
> simplest one worked :-)
> I want to test this in a few places first but this gets nmap-current
> to work on netbsd 5.99.X.
> So far I have tested on osX (darwin 9.7.0) - this evening I will test
> on freebsd 7, 8 and debian-current.
>
> I will look into the sed issue afterward.
>
> thanks,
>   j
>
> --- tcpip.cc.orig     2009-08-31 08:59:30.000000000 -0400
> +++ tcpip.cc  2009-08-31 09:10:28.000000000 -0400
> @@ -3037,7 +3037,7 @@
>    ifr = ifc.ifc_req;
>
>    for (ifr = ifc.ifc_req;
> -       ifr && ifr->ifr_name[0] && (void *) ifr < ifc.ifc_buf + ifc.ifc_len;
> +       ifr && ifr->ifr_name[0] && (void *) ifr < (caddr_t) ifc.ifc_buf + ifc.ifc_len;
>         ifr = (struct ifreq *) ((char *) ifr + len)) {
>      struct sockaddr_in *sin;
>      struct ifreq tmpifr;

I don't understand. How is that any different from this patch, which you
said didn't work?

http://seclists.org/nmap-dev/2009/q3/0800.html

Isn't caddr_t the same as char * on your platform? I would rather use
char * here because it makes it clear we're doing single-byte-aligned
pointer arithmetic.

David Fifield

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org