Re: Feedback requested - XML XSL transform changes

[David Fifield <david () bamsoftware com>]

On Thu, Nov 11, 2010 at 05:01:30PM -0600, Tom Sellers wrote:
> I have attached an updated version of the nmap XML XSL transform
> document, nmap.xsl. I have also attached a sample scan XML file,
> test2.xml.  Just save both in a directory and open test2.xml in a
> browser or use a command line utility to convert to HTML.

I think it looks great! I attached an HTML file that I generated with

xsltproc docs/nmap.xsl test2.xml > test2.html

> Added support for the pre-scan script data.  The output is formatted
> using HTML 'pre' tags.
>     The text format does not match the other tables but but seemed
> to be the only way to
>     format the data into some semblance of readability.  I tried
> replacing the XML encoded
>     line feeds and carriage returns with break tags "<br />" but
> that was not reliable
>     and the encoded \r and \n were not always where they needed to
> be to look correct.
>
>     Also
>     - the top menu entry is conditional and only appears if pre-scan
> data is present
>     - the pre-scan script block is currently at the beginning of the
> page right after
>       the scan summary but can be moved to the end if desired.
>
>
> Added title section for hostscript output
> Added table headers for hostscript output
>
> Fixed a bug in the port script output that caused it to only span 5
> columns instead of 6.
>     Tested this with various levels of debug, verbosity, etc to make
> sure that the
>     number of columns does not change.
>
> Changed color of script output cells in port table as well as
> hostscript and prescan result
>     tables slightly to make visual parsing easier.
>
> Added MAC vendor text to address section
>
>
> Feedback needed on the following:
>
> 1.  Are the colors acceptable?  Is it time for a theme change?

The script output color looks good. I remember Fyodor mentioning that
the red color for closed points should be more subdued. It's the open
ports we care the most about.

> 2.  The 'scan info' link at the top refers to an anchor for data
> that is not displayed.
>     Looking at various versions in SVN I have not been able to find
> a version of the XSL
>     where this data was ever displayed, though I seem to remember
> seeing the data.
>
>     Is this intentional?
>     Should the scan info be displayed or should the link be removed?
>
>     I have added it back at the bottom so that the info can  be
> reviewed to see if it should be kept.

Where you put it looks good.

> 3.  I think the nmap_xsl_version should be incremented as well.  Thoughts?

I don't have an opinion about that.

David Fifield

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/